-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace Requests with PodGroupRequests #4435
base: main
Are you sure you want to change the base?
chore: Replace Requests with PodGroupRequests #4435
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @mimowo |
Signed-off-by: Yuki Iwai <[email protected]>
bb17743
to
09ed96a
Compare
/hold For example, the type is also used to represent capacity. I think calling it Thinking more about the capacity case Requests is misleading too - maybe just call it
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As we discussed in #4355 (comment), we clarified the expected requests. The current
Requests
evokes Pod requests, but actually, it will be a group of Pod requests.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?