Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace Requests with PodGroupRequests #4435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tenzen-y
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As we discussed in #4355 (comment), we clarified the expected requests. The current Requests evokes Pod requests, but actually, it will be a group of Pod requests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2025
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 09ed96a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67c0b60fcd4df40008adae85

@tenzen-y
Copy link
Member Author

/assign @mimowo

@tenzen-y tenzen-y force-pushed the rename-requests-to-pgrequests branch from bb17743 to 09ed96a Compare February 27, 2025 18:59
@mimowo
Copy link
Contributor

mimowo commented Feb 27, 2025

/hold
I'm not convinced this is the right direction. In the comment #4355 (comment) I meant specifically the context of CountIn, but I think the new name is not that good for other contexts.

For example, the type is also used to represent capacity. I think calling it PodGroupRequests it even more confusing in that context. And longer.

Thinking more about the capacity case Requests is misleading too - maybe just call it Resources or ResourcesMap.
Then, depending on the context we could:

  • have better function comments clarifying the role
  • have contextual aliases like PodGroupRequests of Capacity, but I'm not sure if the aliases simplify it

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants