Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --not-in-schema Flag to Helm #5869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isarns
Copy link
Contributor

@isarns isarns commented Feb 25, 2025

This pull request introduces the new --not-in-schema flag for Helm, addressing the request in issue #5813. When enabled, this flag will cause Helm to ignore the .schema.json file, if present, in a chart.

from issue

helm enforces schema validation for the values passed to a chart if the chart defines a schema for the expected values. While this feature might be practical in some use-cases it is a problem when using a helm-chart as dependency when the passed values contain properties for other dependencies or the main chart.

Key Changes:

  • Added the --not-in-schema flag to the Helm command-line options.
  • Updated tests to cover scenarios with and without the flag enabled, ensuring backward compatibility.

This enhancement offers greater flexibility for users facing issues with schema validation, streamlining deployments in environments where strict schema adherence is not required.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isarns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @isarns. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants