-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Affinity to SPOD configuration #1217
Conversation
Signed-off-by: Cosmin Cojocar <[email protected]>
Hi @ccojocar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
@ccojocar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The unit tests failure on macos doesn't seem to be related to this change. It looks like a transient failure. The test passed when executed locally on macos. |
/ok-to-test |
Yes, I've seen those, too. I kicked the test now. |
The code looks good, I just wonder if you think this is worth documenting in the |
I can add a note. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
- Coverage 45.42% 45.42% -0.01%
==========================================
Files 48 48
Lines 5360 5361 +1
==========================================
Hits 2435 2435
- Misses 2805 2806 +1
Partials 120 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
It adds Affinity to the SPOD configuration.
Which issue(s) this PR fixes:
This allows to control the scheduling of spod daemonset pod in a cluster which has nodes with different types of runtimes (e.g. micro-vm, docker, cri-o) which are not tainted but just labeled.
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?