Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Affinity to SPOD configuration #1217

Merged
merged 5 commits into from
Oct 12, 2022

Conversation

ccojocar
Copy link
Contributor

@ccojocar ccojocar commented Oct 11, 2022

What type of PR is this?

/kind api-change

What this PR does / why we need it:

It adds Affinity to the SPOD configuration.

Which issue(s) this PR fixes:

This allows to control the scheduling of spod daemonset pod in a cluster which has nodes with different types of runtimes (e.g. micro-vm, docker, cri-o) which are not tainted but just labeled.

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added Affinity to SPOD configuration.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ccojocar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2022
@ccojocar
Copy link
Contributor Author

/test all

@k8s-ci-robot
Copy link
Contributor

@ccojocar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ccojocar
Copy link
Contributor Author

The unit tests failure on macos doesn't seem to be related to this change. It looks like a transient failure. The test passed when executed locally on macos.

@jhrozek
Copy link
Contributor

jhrozek commented Oct 11, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2022
@jhrozek
Copy link
Contributor

jhrozek commented Oct 11, 2022

The unit tests failure on macos doesn't seem to be related to this change. It looks like a transient failure. The test passed when executed locally on macos.

Yes, I've seen those, too. I kicked the test now.

@jhrozek
Copy link
Contributor

jhrozek commented Oct 11, 2022

The code looks good, I just wonder if you think this is worth documenting in the installation-usage.md document?

@ccojocar
Copy link
Contributor Author

The code looks good, I just wonder if you think this is worth documenting in the installation-usage.md document?

I can add a note.

@codecov-commenter
Copy link

Codecov Report

Merging #1217 (a9dd393) into main (90dc84c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
- Coverage   45.42%   45.42%   -0.01%     
==========================================
  Files          48       48              
  Lines        5360     5361       +1     
==========================================
  Hits         2435     2435              
- Misses       2805     2806       +1     
  Partials      120      120              

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1c3de30 into kubernetes-sigs:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants