config: Allow enabling the log enricher on install time using the ENABLE_LOG_ENRICHER variable
#1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 45.42% 45.38% -0.04%
==========================================
Files 48 48
Lines 5361 5365 +4
==========================================
Hits 2435 2435
- Misses 2806 2810 +4
Partials 120 120 |
…ABLE_LOG_ENRICHER` variable Some installations might want to enable the log enricher at install time. Using an environment variable seems like a nice way of doing that, for example because then it's possible to use a Subscription object when installing using OLM.
jhrozek
force-pushed
the
webhook_enable_env_var
branch
from
22695e0 to
be64058
Compare
saschagrunert
approved these changes
Oct 17, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
|
/test pull-security-profiles-operator-test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Some installations might want to enable the log enricher at install
time. Using an environment variable seems like a nice way of doing that,
for example because then it's possible to use a Subscription object when
installing using OLM.
Which issue(s) this PR fixes:
Fixes #1167
Does this PR have test?
no
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?