-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable the daemon resource requirements #1291
Configurable the daemon resource requirements #1291
Conversation
/assign @saschagrunert |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
- Coverage 43.92% 43.90% -0.03%
==========================================
Files 49 49
Lines 5514 5517 +3
==========================================
Hits 2422 2422
- Misses 2972 2975 +3
Partials 120 120 |
It would be nice to document the new options. I'm on the fence about a test, ideally we should have everything tested (and e.g. we do have tests for webhook label changes), but the patch "just" adds a public kube type, so..shrug. By the way, thanks a lot for doing this performance and scalability work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nits, but overall lgtm from me. Thank you for working on this @ccojocar.
I'll add some docs and tests. |
dbda365
to
0bb8398
Compare
/test all |
Co-authored-by: Paulo Gomes <[email protected]>
@saschagrunert it seems that this one passed. It just requires a review. Please could you have a look? Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
It makes configurable the daemon resource requirements. This is useful when the daemon requires different resource requirements due to the cluster size (e.g. number of pods is watching for).
Which issue(s) this PR fixes:
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?