Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable the daemon resource requirements #1291

Merged

Conversation

ccojocar
Copy link
Contributor

@ccojocar ccojocar commented Nov 10, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

It makes configurable the daemon resource requirements. This is useful when the daemon requires different resource requirements due to the cluster size (e.g. number of pods is watching for).

Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Make the daemon resource requirements configurable.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2022
@ccojocar ccojocar changed the title configurable daemon resources Configurable the daemon resource requirements Nov 10, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 10, 2022
@ccojocar
Copy link
Contributor Author

/assign @saschagrunert

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #1291 (c855f1c) into main (868709e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   43.92%   43.90%   -0.03%     
==========================================
  Files          49       49              
  Lines        5514     5517       +3     
==========================================
  Hits         2422     2422              
- Misses       2972     2975       +3     
  Partials      120      120              

@jhrozek
Copy link
Contributor

jhrozek commented Nov 10, 2022

It would be nice to document the new options. I'm on the fence about a test, ideally we should have everything tested (and e.g. we do have tests for webhook label changes), but the patch "just" adds a public kube type, so..shrug.

By the way, thanks a lot for doing this performance and scalability work!

Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, but overall lgtm from me. Thank you for working on this @ccojocar.

@ccojocar
Copy link
Contributor Author

It would be nice to document the new options. I'm on the fence about a test, ideally we should have everything tested (and e.g. we do have tests for webhook label changes), but the patch "just" adds a public kube type, so..shrug.

I'll add some docs and tests.

@ccojocar ccojocar force-pushed the configurable-daemon-resources branch from dbda365 to 0bb8398 Compare November 11, 2022 11:04
@ccojocar
Copy link
Contributor Author

@jhrozek @pjbgf I think that I addressed all your remarks. I added some documentation and an e2e test.

@ccojocar
Copy link
Contributor Author

/test all

@ccojocar
Copy link
Contributor Author

@saschagrunert it seems that this one passed. It just requires a review. Please could you have a look? Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@ccojocar ccojocar requested review from JAORMX and removed request for Vincent056 November 14, 2022 10:16
@k8s-ci-robot k8s-ci-robot merged commit bb19370 into kubernetes-sigs:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants