Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing spo image repo & tag in helm charts to make it configurable #1396

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

rahulroshan-kachchap
Copy link
Contributor

@rahulroshan-kachchap rahulroshan-kachchap commented Jan 2, 2023

What type of PR is this?

kind feature

What this PR does / why we need it:

This enables users to have better control over what images/tags they deploy when using the official SPO helm chart, instead of having to create their own.

Which issue(s) this PR fixes:

Fixes #1334

Does this PR have test?

Tested the above changes with spoimage repository set to gcr.io/k8s-staging-sp-operator/security-profiles-operator and spoimage tag set to latest.
Image pulled successfully.

Does this PR introduce a user-facing change?

Added registry, repository & tag in values.yaml to make SPO repo & image values configurable in helm charts.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @rahulroshan-kachchap. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2023
@rahulroshan-kachchap
Copy link
Contributor Author

rahulroshan-kachchap commented Jan 2, 2023

@JAORMX I created a fresh PR and closed the previous one(#1387) - I messed it up in squashing the commits.

@JAORMX
Copy link
Contributor

JAORMX commented Jan 2, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Merging #1396 (53ed51c) into main (3e42cf0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1396   +/-   ##
=======================================
  Coverage   44.13%   44.13%           
=======================================
  Files          50       50           
  Lines        5651     5651           
=======================================
  Hits         2494     2494           
  Misses       3037     3037           
  Partials      120      120           

@rahulroshan-kachchap
Copy link
Contributor Author

/retest-required

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 12, 2023
@saschagrunert
Copy link
Member

@rahulroshan-kachchap please rebase to get the latest CI fixes in :)

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2023
@rahulroshan-kachchap
Copy link
Contributor Author

@ccojocar @Vincent056 Can you please review this and get it merged

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulroshan-kachchap, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit bf24f5c into kubernetes-sigs:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm: Make all images configurable values
5 participants