-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing spo image repo & tag in helm charts to make it configurable #1396
Exposing spo image repo & tag in helm charts to make it configurable #1396
Conversation
Hi @rahulroshan-kachchap. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 44.13% 44.13%
=======================================
Files 50 50
Lines 5651 5651
=======================================
Hits 2494 2494
Misses 3037 3037
Partials 120 120 |
/retest-required |
@rahulroshan-kachchap please rebase to get the latest CI fixes in :) |
53ed51c
to
a6d46fc
Compare
@ccojocar @Vincent056 Can you please review this and get it merged |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulroshan-kachchap, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
kind feature
What this PR does / why we need it:
This enables users to have better control over what images/tags they deploy when using the official SPO helm chart, instead of having to create their own.
Which issue(s) this PR fixes:
Fixes #1334
Does this PR have test?
Tested the above changes with spoimage repository set to gcr.io/k8s-staging-sp-operator/security-profiles-operator and spoimage tag set to latest.
Image pulled successfully.
Does this PR introduce a user-facing change?