Use mergo for syscall merge #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
use-mergo
branch
2 times, most recently
from
cf0bcf4 to
d19b9b2
Compare
The merging itself is not that intelligent any more, but we preserve possible args and error return values. It also makes the merge more simple, while we still sort the syscall names and actions. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
use-mergo
branch
from
d19b9b2 to
7bd8416
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
- Coverage 48.97% 48.81% -0.17%
==========================================
Files 69 69
Lines 6748 6744 -4
==========================================
- Hits 3305 3292 -13
- Misses 3318 3324 +6
- Partials 125 128 +3 |
ccojocar
approved these changes
Mar 31, 2023
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The merging itself is not that intelligent any more, but we preserve possible args and error return values. It also makes the merge more simple, while we still sort the syscall names and actions.
Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?