Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a base e2e test for apparmor #1684

Merged
merged 3 commits into from
May 16, 2023
Merged

Add a base e2e test for apparmor #1684

merged 3 commits into from
May 16, 2023

Conversation

ccojocar
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This e2e test covers the basic use case which loads and unloads apparmor profiles into the cluster nodes.

This is based on work done in #1074.

Which issue(s) this PR fixes:

Relates #718

Does this PR have test?

Yes

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Add a e2e test for apparmor profile which covers base functionlity such as loading and unloading profiles itno the cluster nodes.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2023
@k8s-ci-robot k8s-ci-robot requested review from JAORMX and Vincent056 May 16, 2023 08:28
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2023
@ccojocar
Copy link
Contributor Author

/assign @saschagrunert

@ccojocar ccojocar mentioned this pull request May 16, 2023
Closed
@ccojocar
Copy link
Contributor Author

/assign @pjbgf

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023 •
edited
Loading

Codecov Report

Merging #1684 (c86e270) into main (2b3785f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1684   +/-   ##
=======================================
  Coverage   49.35%   49.35%           
=======================================
  Files          71       71           
  Lines        6930     6930           
=======================================
  Hits         3420     3420           
  Misses       3380     3380           
  Partials      130      130

ccojocar added 3 commits May 16, 2023 10:56
@ccojocar
Add a base e2e test for apparmor
d63519b 
This e2e test covers the basic use case which loads and unloads apparmor profiles into the cluster nodes.

Signed-off-by: Cosmin Cojocar <[email protected]>
@ccojocar
Remove unused lint directive
138dacd 
Signed-off-by: Cosmin Cojocar <[email protected]>
@ccojocar
Fix the installation of zeitgeist tool on osx
c86e270 
Signed-off-by: Cosmin Cojocar <[email protected]>
@ccojocar ccojocar force-pushed the apparmor-e2e-test branch from d66f4e3 to c86e270 Compare May 16, 2023 08:56
saschagrunert
saschagrunert approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great work thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ccojocar,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pjbgf
Copy link
Member

pjbgf commented May 16, 2023

Great job @ccojocar, thank you for working on this. 🙇

/lgtm

@ccojocar
Copy link
Contributor Author

/test e2e-fedora

@k8s-ci-robot
Copy link
Contributor

@ccojocar: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-security-profiles-operator-build
  • /test pull-security-profiles-operator-build-image
  • /test pull-security-profiles-operator-test-e2e
  • /test pull-security-profiles-operator-test-unit
  • /test pull-security-profiles-operator-verify

Use /test all to run all jobs.

In response to this:

/test e2e-fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@ccojocar: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-security-profiles-operator-build
  • /test pull-security-profiles-operator-build-image
  • /test pull-security-profiles-operator-test-e2e
  • /test pull-security-profiles-operator-test-unit
  • /test pull-security-profiles-operator-verify

Use /test all to run all jobs.

In response to this:

/test e2e-fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ccojocar
Copy link
Contributor Author

/test pull-security-profiles-operator-test-e2e

@k8s-ci-robot
Copy link
Contributor

@ccojocar: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-security-profiles-operator-build
  • /test pull-security-profiles-operator-build-image
  • /test pull-security-profiles-operator-test-e2e
  • /test pull-security-profiles-operator-test-unit
  • /test pull-security-profiles-operator-verify

Use /test all to run all jobs.

In response to this:

/test e2e-fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ccojocar
Copy link
Contributor Author

/test pull-security-profiles-operator-test-e2e

@ccojocar
Copy link
Contributor Author

/retest

1 similar comment
@ccojocar
Copy link
Contributor Author

/retest

@ccojocar
Copy link
Contributor Author

/test pull-security-profiles-operator-test-e2e

@k8s-ci-robot k8s-ci-robot merged commit 6340b86 into kubernetes-sigs:main May 16, 2023
@pjbgf pjbgf mentioned this pull request May 22, 2023
Closed
7 tasks
@ccojocar ccojocar deleted the apparmor-e2e-test branch May 17, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@JAORMX JAORMX Awaiting requested review from JAORMX

@Vincent056 Vincent056 Awaiting requested review from Vincent056

Assignees

@saschagrunert saschagrunert

@pjbgf pjbgf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccojocar @codecov-commenter @k8s-ci-robot @pjbgf @saschagrunert