Fix namespace selector comparison for webhook #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
saschagrunert
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 49.32% 47.32% -2.01%
==========================================
Files 72 77 +5
Lines 7008 7352 +344
==========================================
+ Hits 3457 3479 +22
- Misses 3420 3742 +322
Partials 131 131 |
We should only compare supported labels and not everything on the namespace, otherwise we can end up being stuck in a `SPOD` with the `UPDATING` state. We now only compare supported webhook labels and use them as indicator if it requires and update or not. Fixes kubernetes-sigs#1981 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
webhook-label-fix
branch
from
68b7a91 to
d7f11ef
Compare
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@kubernetes-sigs/security-profiles-operator-maintainers PTAL |
JAORMX
approved these changes
Nov 28, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We should only compare supported labels and not everything on the namespace, otherwise we can end up being stuck in a
SPODwith theUPDATINGstate. We now only compare supported webhook labels and use them as indicator if it requires and update or not.Which issue(s) this PR fixes:
Fixes #1981
Does this PR have test?
Yes
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?