-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppArmor: make policy field optional if abstract policy is specified #2469
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2469 +/- ##
==========================================
- Coverage 45.50% 41.84% -3.67%
==========================================
Files 79 109 +30
Lines 7782 16025 +8243
==========================================
+ Hits 3541 6705 +3164
- Misses 4099 8824 +4725
- Partials 142 496 +354 |
I think you need to regenerate the bundle since the profile manifest was changed. |
Please rebase this one as well. |
18341fe
to
2324dfe
Compare
The OLM bundles do not seem to be up to date: https://github.com/kubernetes-sigs/security-profiles-operator/actions/runs/11300455856/job/31483016900?pr=2469 |
Thanks @saschagrunert! Is it intentional that |
Hm, we could add it indeed. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, mhils, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR makes the
policy
field optional for AppArmor policies.Which issue(s) this PR fixes:
#2388
Does this PR have test?
Covered by existing tests
Does this PR introduce a user-facing change?