Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google analytics: use GA4 site tag for v1.24 #36322

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Google analytics: use GA4 site tag for v1.24 #36322

merged 1 commit into from
Aug 27, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 26, 2022 •
edited
Loading

/cc @nate-double-u

@netlify
Copy link

netlify bot commented Aug 26, 2022 •
edited
Loading

✅ Deploy Preview for k8s-v1-24 ready!

Name Link
🔨 Latest commit 1142a02
🔍 Latest deploy log https://app.netlify.com/sites/k8s-v1-24/deploys/6308864f1b006e00096b01a7
😎 Deploy Preview https://deploy-preview-36322--k8s-v1-24.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 26, 2022
@chalin chalin mentioned this pull request Aug 26, 2022
Closed
23 tasks
@chalin
Copy link
Contributor Author

chalin commented Aug 26, 2022

/cc @onlydole @jimangel @sftim @reylejano (who approved #36010).

@chalin chalin force-pushed the chalin-im-ga4-release-1.24-2022-08-26 branch from 1bfd208 to 1142a02 Compare August 26, 2022 08:37
@chalin
Copy link
Contributor Author

chalin commented Aug 26, 2022

/cc @onlydole

@k8s-ci-robot k8s-ci-robot requested a review from onlydole August 26, 2022 08:38
@chalin
Copy link
Contributor Author

chalin commented Aug 26, 2022

/cc @reylejano

@k8s-ci-robot k8s-ci-robot requested a review from reylejano August 26, 2022 08:39
@reylejano
Copy link
Member

This is part of the CNCF-wide effort to upgrade project websites to GA4 since Google has deprecated Universal Analytics (UA)
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@sftim
Copy link
Contributor

sftim commented Aug 26, 2022

/lgtm
/hold

I'm not sure if the change to main has gone live yet. OK to unhold once main is updated (which makes this a backport).

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d483cabab0a87025864e6aff46e6d1ec77e8fb69

@chalin
Copy link
Contributor Author

chalin commented Aug 26, 2022

I'm not sure if the change to main has gone live yet. OK to unhold once main is updated (which makes this a backport).

Yes, the change to main, #36010, is live.

@sftim
Copy link
Contributor

sftim commented Aug 27, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2022
@sftim
Copy link
Contributor

sftim commented Aug 27, 2022

Will we backport this change to older docs releases?

@k8s-ci-robot k8s-ci-robot merged commit 7a39b4f into kubernetes:release-1.24 Aug 27, 2022
@chalin chalin deleted the chalin-im-ga4-release-1.24-2022-08-26 branch September 28, 2022 20:34
@chalin
Copy link
Contributor Author

chalin commented Sep 28, 2022

Will we backport this change to older docs releases?

Yes. See the "Other" section of #35299:

image

Please add any further comments to that issue.

@chalin chalin mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalin @reylejano @k8s-ci-robot @sftim