feat(azure-cosmosdb): add session context for a user mongodb #7436

crisjy · 2024-12-27T08:39:39Z

Fixes # (issue)

vercel · 2024-12-27T08:39:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-docs	✅ Ready (Inspect)	Visit Preview		Jan 18, 2025 8:12am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-api-refs	⬜️ Ignored (Inspect)			Jan 18, 2025 8:12am

jacoblee93

Seems reasonable to me!

@sinedied do you mind giving this a look?

sinedied

Thanks @crisjy !
The context handling looks fine here, but you're missing user handling, which is needed to list/delete sessions otherwise you have no distinction of users.

What we did in the other CosmosDB implementation is make userId parameter optional in the DB options and set it to anonymous by default to keep compatibility with other implementation (or when user handling is not needed).

libs/langchain-azure-cosmosdb/src/chat_histories/mongodb.ts

sinedied · 2025-01-03T10:05:44Z

libs/langchain-azure-cosmosdb/src/chat_histories/mongodb.ts

+  async clearAllSessions() {
+    await this.initialize();
+    try {
+      await this.collection.deleteMany({});


This would delete all sessions for all users, which might not be the intended behavior... I think you missed the user handling here

yep, add user id as handle for sessions, thank you for your comment!

I think you forgot to update this call to filter it for the current user only

add user id as handler to clear sessions

jacoblee93 · 2025-01-10T21:51:27Z

@crisjy let me know when this is ready for another look!

crisjy · 2025-01-12T15:13:47Z

@crisjy let me know when this is ready for another look!

@jacoblee93 @sinedied resolve comments for this pr, sorry for delay, could you help me to have a look? thank you!

sinedied

Thanks, the update with userId support looks great!

Though you forgot to add the filter for the current userId on the getAllSessions() and clearAllSessions() methods, as it should apply only to the current users. Should be a quick fix :)

sinedied · 2025-01-13T10:48:58Z

libs/langchain-azure-cosmosdb/src/chat_histories/mongodb.ts

+
+  async getAllSessions(): Promise<ChatSessionMongo[]> {
+    await this.initialize();
+    const documents = await this.collection.find().toArray();


Missing user filter here

sinedied · 2025-01-13T10:49:38Z

libs/langchain-azure-cosmosdb/src/chat_histories/mongodb.ts

+  async clearAllSessions() {
+    await this.initialize();
+    try {
+      await this.collection.deleteMany({});


I think you forgot to update this call to filter it for the current user only

crisjy · 2025-01-14T15:11:02Z

@sinedied @jacoblee93 comments resolved, could you help me have another look? Thank you!

sinedied · 2025-01-14T16:48:01Z

LGTM, thanks!

crisjy · 2025-01-15T02:21:48Z

@jacoblee93 Hi jacob, could you help me have another look at this PR, thanks!

jacoblee93 · 2025-01-18T07:57:00Z

libs/langchain-azure-cosmosdb/src/chat_histories/mongodb.ts

+
+    try {
+      await this.collection.updateOne(
+        { [ID_KEY]: this.sessionId },


Do we need [ID_USER]: this.userId, here too?

I assume this is sufficient in this case to just pass id?

jacoblee93

Thank you!

* Rename auth method in docs * fix(core): Fix trim messages mutation bug (langchain-ai#7547) * release(core): 0.3.31 (langchain-ai#7548) * fix(community): Updated Embeddings URL (langchain-ai#7545) * fix(community): make sure guardrailConfig can be added even with anthropic models (langchain-ai#7542) * docs: Fix PGVectorStore import in install dependencies (TypeScript) example (langchain-ai#7533) * fix(community): Airtable url (langchain-ai#7532) * docs: Fix typo in OpenAIModerationChain example (langchain-ai#7528) * docs: Resolves langchain-ai#7483, resolves langchain-ai#7274 (langchain-ai#7505) Co-authored-by: jacoblee93 <[email protected]> * docs: Rename auth method in IBM docs (langchain-ai#7524) * docs: correct misspelling (langchain-ai#7522) Co-authored-by: jacoblee93 <[email protected]> * release(community): 0.3.25 (langchain-ai#7549) * feat(azure-cosmosdb): add session context for a user mongodb (langchain-ai#7436) Co-authored-by: jacoblee93 <[email protected]> * release(azure-cosmosdb): 0.2.7 (langchain-ai#7550) * fix(ci): Fix build (langchain-ai#7551) * feat(anthropic): Add Anthropic PDF support (document type) in invoke (langchain-ai#7496) Co-authored-by: jacoblee93 <[email protected]> * release(anthropic): 0.3.12 (langchain-ai#7552) * chore(core,langchain,community): Relax langsmith deps (langchain-ai#7556) * release(community): 0.3.26 (langchain-ai#7557) * release(core): 0.3.32 (langchain-ai#7558) * Release 0.3.12 (langchain-ai#7559) * Add deployment chat to chat class * Upadate Watsonx sdk * Rework interfaces in llms as well * Bump watsonx-ai sdk version * Remove unused code * Add fake auth --------- Co-authored-by: Jacob Lee <[email protected]> Co-authored-by: Jacky Chen <[email protected]> Co-authored-by: Mohamed Belhadj <[email protected]> Co-authored-by: Brian Ploetz <[email protected]> Co-authored-by: Eduard-Constantin Ibinceanu <[email protected]> Co-authored-by: Jonathan V <[email protected]> Co-authored-by: ucev <[email protected]> Co-authored-by: crisjy <[email protected]> Co-authored-by: Adham Badr <[email protected]>

* Rename auth method in docs * fix(core): Fix trim messages mutation bug (langchain-ai#7547) * release(core): 0.3.31 (langchain-ai#7548) * fix(community): Updated Embeddings URL (langchain-ai#7545) * fix(community): make sure guardrailConfig can be added even with anthropic models (langchain-ai#7542) * docs: Fix PGVectorStore import in install dependencies (TypeScript) example (langchain-ai#7533) * fix(community): Airtable url (langchain-ai#7532) * docs: Fix typo in OpenAIModerationChain example (langchain-ai#7528) * docs: Resolves langchain-ai#7483, resolves langchain-ai#7274 (langchain-ai#7505) Co-authored-by: jacoblee93 <[email protected]> * docs: Rename auth method in IBM docs (langchain-ai#7524) * docs: correct misspelling (langchain-ai#7522) Co-authored-by: jacoblee93 <[email protected]> * release(community): 0.3.25 (langchain-ai#7549) * feat(azure-cosmosdb): add session context for a user mongodb (langchain-ai#7436) Co-authored-by: jacoblee93 <[email protected]> * release(azure-cosmosdb): 0.2.7 (langchain-ai#7550) * fix(ci): Fix build (langchain-ai#7551) * feat(anthropic): Add Anthropic PDF support (document type) in invoke (langchain-ai#7496) Co-authored-by: jacoblee93 <[email protected]> * release(anthropic): 0.3.12 (langchain-ai#7552) * chore(core,langchain,community): Relax langsmith deps (langchain-ai#7556) * release(community): 0.3.26 (langchain-ai#7557) * release(core): 0.3.32 (langchain-ai#7558) * Release 0.3.12 (langchain-ai#7559) * fix(core): Prevent cache misses from triggering model start callback runs twice (langchain-ai#7565) * fix(core): Ensure that cached flag in run extras is only set for cache hits (langchain-ai#7566) * release(core): 0.3.33 (langchain-ai#7567) * feat(community): Adds graph_document to export list (langchain-ai#7555) Co-authored-by: quantropi-minh <[email protected]> Co-authored-by: jacoblee93 <[email protected]> * fix(langchain): Fix ZeroShotAgent createPrompt with correct formatted tool names (langchain-ai#7510) * docs: Add document for AzureCosmosDBMongoChatMessageHistory (langchain-ai#7519) Co-authored-by: root <root@CPC-yangq-FRSGK> * fix(langchain): Allow pulling hub prompts with associated models (langchain-ai#7569) * fix(community,aws): Update handleLLMNewToken to include chunk metadata (langchain-ai#7568) Co-authored-by: jacoblee93 <[email protected]> * feat(community): Provide fallback relationshipType in case it is not present in graph_transformer (langchain-ai#7521) Co-authored-by: quantropi-minh <[email protected]> Co-authored-by: jacoblee93 <[email protected]> * docs: Add redirect (langchain-ai#7570) * fix(langchain,core): Add shim for hub mustache templates with nested input variables (langchain-ai#7581) * fix(chat-models): honor disableStreaming even for `generateUncached` (langchain-ai#7575) * release(core): 0.3.34 (langchain-ai#7584) * feat(langchain): Add hub entrypoint with automatic dynamic entrypoint of models (langchain-ai#7583) * chore(ollama): Export `OllamaEmbeddingsParams` interface (langchain-ai#7574) * docs: Clarify tool creation process in structured outputs documentation (langchain-ai#7578) Co-authored-by: Sahar Shemesh <[email protected]> Co-authored-by: jacoblee93 <[email protected]> * fix(community): Set awaitHandlers to true in upstash ratelimit (langchain-ai#7571) Co-authored-by: Jacob Lee <[email protected]> * fix(core): Fix trim messages mutation (langchain-ai#7585) * feat(openai): Make only AzureOpenAI respect Azure env vars, remove class defaults, update withStructuredOutput defaults (langchain-ai#7535) * fix(community): Make postgresConnectionOptions optional in PostgresRecordManager (langchain-ai#7580) Co-authored-by: jacoblee93 <[email protected]> * release(community): 0.3.27 (langchain-ai#7586) * release(ollama): 0.1.5 (langchain-ai#7587) * Release 0.3.13 (langchain-ai#7588) * release(openai): 0.4.0 (langchain-ai#7589) * release(core): 0.3.35 (langchain-ai#7590) * fix(ci): Update lock (langchain-ai#7591) * feat(core): Allow passing returnDirect in tool wrapper params (langchain-ai#7594) * release(core): 0.3.36 (langchain-ai#7595) * fix(openai): Revert Azure default withStructuredOutput changes (langchain-ai#7596) * release(openai): 0.4.1 (langchain-ai#7597) * feat(openai): Refactor to allow easier subclassing (langchain-ai#7598) * release(openai): 0.4.2 (langchain-ai#7599) * feat(deepseek): Adds Deepseek integration (langchain-ai#7604) * release(deepseek): 0.0.1 (langchain-ai#7608) * feat: update Novita AI doc (langchain-ai#7602) * Add deployment chat to chat class * feat(langchain): Add DeepSeek to initChatModel (langchain-ai#7609) * Release 0.3.14 (langchain-ai#7611) * fix: Add test for pdf uploads anthropic (langchain-ai#7613) * feat: Update google genai to support file uploads (langchain-ai#7612) * chore(google-genai): Drop .only in test (langchain-ai#7614) * release(google-genai): 0.1.7 (langchain-ai#7615) * Upadate Watsonx sdk * fix(core): Fix stream events bug when errors are thrown too quickly during iteration (langchain-ai#7617) * release(core): 0.3.37 (langchain-ai#7619) * fix(langchain): Fix Groq import for hub (langchain-ai#7620) * docs: update README/intro * Release 0.3.15 * feat(community): improve support for Tavily search tool args (langchain-ai#7561) * feat(community): Add boolean metadata type support in Supabase structured query translator (langchain-ai#7601) * feat(google-genai): Add support for fileUri in media type in Google GenAI (langchain-ai#7621) Co-authored-by: Jacob Lee <[email protected]> * release(google-genai): 0.1.8 (langchain-ai#7628) * release(community): 0.3.28 (langchain-ai#7629) * Rework interfaces in llms as well * Bump watsonx-ai sdk version * Remove unused code * Add fake auth * Fix broken changes --------- Co-authored-by: Jacob Lee <[email protected]> Co-authored-by: Jacky Chen <[email protected]> Co-authored-by: Mohamed Belhadj <[email protected]> Co-authored-by: Brian Ploetz <[email protected]> Co-authored-by: Eduard-Constantin Ibinceanu <[email protected]> Co-authored-by: Jonathan V <[email protected]> Co-authored-by: ucev <[email protected]> Co-authored-by: crisjy <[email protected]> Co-authored-by: Adham Badr <[email protected]> Co-authored-by: Minh Ha <[email protected]> Co-authored-by: quantropi-minh <[email protected]> Co-authored-by: Chi Thu Le <[email protected]> Co-authored-by: fatmelon <[email protected]> Co-authored-by: root <root@CPC-yangq-FRSGK> Co-authored-by: Mohamad Mohebifar <[email protected]> Co-authored-by: David Duong <[email protected]> Co-authored-by: Brace Sproul <[email protected]> Co-authored-by: Matus Gura <[email protected]> Co-authored-by: Sahar Shemesh <[email protected]> Co-authored-by: Sahar Shemesh <[email protected]> Co-authored-by: Cahid Arda Öz <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: vbarda <[email protected]> Co-authored-by: Vadym Barda <[email protected]> Co-authored-by: Hugo Borsoni <[email protected]> Co-authored-by: Arman Ghazaryan <[email protected]> Co-authored-by: Andy <[email protected]>

crisjc-e added 2 commits December 27, 2024 08:36

add session context for a user mongodb

511f3e1

add session context for a user mongodb

2ae8412

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 27, 2024

Merge branch 'langchain-ai:main' into chathistory_session

c823f68

dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Dec 27, 2024

format

c2a6775

vercel bot deployed to Preview – langchainjs-docs December 27, 2024 09:07 View deployment

Merge branch 'main' into chathistory_session

d48e3fd

vercel bot deployed to Preview – langchainjs-docs December 30, 2024 06:31 View deployment

jacoblee93 reviewed Jan 2, 2025

View reviewed changes

jacoblee93 added question Further information is requested lgtm PRs that are ready to be merged as-is labels Jan 2, 2025

sinedied suggested changes Jan 3, 2025

View reviewed changes

Merge branch 'langchain-ai:main' into chathistory_session

46c2ab3

vercel bot deployed to Preview – langchainjs-docs January 9, 2025 03:03 View deployment

jacoblee93 removed the lgtm PRs that are ready to be merged as-is label Jan 10, 2025

resolve comments

4fdbd6a

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 12, 2025

vercel bot deployed to Preview – langchainjs-docs January 12, 2025 15:25 View deployment

sinedied suggested changes Jan 13, 2025

View reviewed changes

resolve comment

8de828d

vercel bot deployed to Preview – langchainjs-docs January 14, 2025 03:56 View deployment

resolve comment

0490feb

vercel bot deployed to Preview – langchainjs-docs January 14, 2025 06:20 View deployment

sinedied approved these changes Jan 14, 2025

View reviewed changes

jacoblee93 reviewed Jan 18, 2025

View reviewed changes

jacoblee93 approved these changes Jan 18, 2025

View reviewed changes

dosubot bot added the lgtm PRs that are ready to be merged as-is label Jan 18, 2025

jacoblee93 changed the title ~~add session context for a user mongodb~~ feat(azure-cosmosdb): add session context for a user mongodb Jan 18, 2025

Format

e0d1790

jacoblee93 removed the question Further information is requested label Jan 18, 2025

vercel bot deployed to Preview – langchainjs-docs January 18, 2025 08:12 View deployment

jacoblee93 merged commit 3a1131a into langchain-ai:main Jan 18, 2025
25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(azure-cosmosdb): add session context for a user mongodb #7436

feat(azure-cosmosdb): add session context for a user mongodb #7436

crisjy commented Dec 27, 2024

vercel bot commented Dec 27, 2024 •

edited

Loading

jacoblee93 left a comment

sinedied left a comment

sinedied Jan 3, 2025

crisjy Jan 12, 2025

sinedied Jan 13, 2025

crisjy Jan 14, 2025

jacoblee93 commented Jan 10, 2025

crisjy commented Jan 12, 2025

sinedied left a comment

sinedied Jan 13, 2025

sinedied Jan 13, 2025

crisjy commented Jan 14, 2025

sinedied commented Jan 14, 2025

crisjy commented Jan 15, 2025

jacoblee93 Jan 18, 2025

jacoblee93 left a comment

feat(azure-cosmosdb): add session context for a user mongodb #7436

feat(azure-cosmosdb): add session context for a user mongodb #7436

Conversation

crisjy commented Dec 27, 2024

vercel bot commented Dec 27, 2024 • edited Loading

jacoblee93 left a comment

Choose a reason for hiding this comment

sinedied left a comment

Choose a reason for hiding this comment

sinedied Jan 3, 2025

Choose a reason for hiding this comment

crisjy Jan 12, 2025

Choose a reason for hiding this comment

sinedied Jan 13, 2025

Choose a reason for hiding this comment

crisjy Jan 14, 2025

Choose a reason for hiding this comment

jacoblee93 commented Jan 10, 2025

crisjy commented Jan 12, 2025

sinedied left a comment

Choose a reason for hiding this comment

sinedied Jan 13, 2025

Choose a reason for hiding this comment

sinedied Jan 13, 2025

Choose a reason for hiding this comment

crisjy commented Jan 14, 2025

sinedied commented Jan 14, 2025

crisjy commented Jan 15, 2025

jacoblee93 Jan 18, 2025

Choose a reason for hiding this comment

jacoblee93 left a comment

Choose a reason for hiding this comment

vercel bot commented Dec 27, 2024 •

edited

Loading