feat: react agent parser is replacing all '"' - in the text and this … #7707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is incorrect, we can not parse a json
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:nit
|
Thanks for this! Could you add an integration test where this was failing? |
dosubot
bot
added
size:S
@jacoblee93 i added langchain/src/tests/react_agent_output_parser.test.ts |
benjamincburns
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is incorrect, we can not parse a json
Fixes # (issue)
E.g.
console.log('"hello world"'.replace(/^"|"$/g, "")); // Output: hello world
console.log('"hello "world" "'.replace(/^"|"$/g, "")); // Output: hello "world"
console.log('"hello"world"'.replace(/^"|"$/g, "")); // Output: hello"world
console.log('hello world'.replace(/^"|"$/g, "")); // Output: hello world (unchanged)