fix: Issues related to the deletion of conversation_id (#12488) #12665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
laipz8200
reviewed
Jan 13, 2025
|
I suggest you leave a comment on the origin issue and wait for the assignment. Next time, let’s try to be more organized! |
Sorry, I don't know about this process. The document says "start coding".Next time I will follow the process. |
jiandanfeng
force-pushed
the
fix-bug-12488
branch
from
74a6788 to
9cd01e7
Compare
laipz8200
requested changes
Jan 13, 2025
jiandanfeng
force-pushed
the
fix-bug-12488
branch
from
9cd01e7 to
7067638
Compare
crazywoola
approved these changes
Jan 21, 2025
crazywoola
approved these changes
Jan 21, 2025
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Jan 21, 2025
* commit '6db3ae9b8ec2f8491e2c9355056a8693ecd67f47': (22 commits) chore: remove webapp ga (langgenius#12909) fix: variable panel scrollable (langgenius#12769) fix: OpenAI o1 Bad Request Error (langgenius#12839) Update deepseek model configuration (langgenius#12899) fix: external dataset hit test display issue(langgenius#12564) (langgenius#12612) add deepseek-reasoner (langgenius#12898) chore(fix): Invalid quotes for using Array[String] in HTTP request node as JSON body (langgenius#12761) fix: Issues related to the deletion of conversation_id (langgenius#12488) (langgenius#12665) chore(lint): fix quotes for f-string formatting by bumping ruff to 0.9.x (langgenius#12702) feat:Support Minimax-Text-01 (langgenius#12763) fix: serply credential check query might return empty records (langgenius#12784) feat: allow updating chunk settings for the existing documents (langgenius#12833) fix: SparkLite API Auth error (langgenius#12781) (langgenius#12790) fix: "parmas" spelling mistake. (langgenius#12875) Fix suggested_question_prompt (langgenius#12738) fix(i18n): correct typo in zh-Hant translation (langgenius#12852) chore: fix chinese translation for 'recall' (langgenius#12772) fix: DeepSeek API Error with response format active (text and json_object) (langgenius#12747) feat: enhance credential extraction logic based on configurate method (langgenius#12853) fix: Fix rerank model switching issue (langgenius#12721) ... # Conflicts: # api/core/tools/utils/message_transformer.py # api/poetry.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the conversation_id is deleted, chat with conversation_id again, returning Conversation Not Exists.
Fixes #12488
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods