-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dollar Sign Handling in Markdown #13178
fix: Dollar Sign Handling in Markdown #13178
Conversation
@tomoyuki28jp @rainchen @iwaim @gijigae @crazywoola Can anyone of you review my PR? Excited to begin contributing to the repo. |
@crazywoola I updated the PR, turns out the issue was not in the preprocessing but the rendering. I have simply added the But now can you test it again, I am having some issues from my end testing it. |
You can revert the |
Summary
Fix Dollar Sign Handling in Markdown, fixes #13149.
Problem
Regular text containing dollar signs (e.g., currency values like "$29 and $199") was being incorrectly interpreted as LaTeX math expressions, causing rendering issues in the markdown output.
Solution
Added the
singleDollarTextMath: false
option to the RemarkMath plugin configuration. This ensures that:Impact
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods