Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(message): optimize message loading and reduce SQL queries #13720

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

hundredwz
Copy link
Contributor

@hundredwz hundredwz commented Feb 14, 2025

Summary

  • Optimize messages loading logic to reduce database queries
  • Change service_api message fetching order to match docs (descending order)

Fixes #13723

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

- Optimize messages loading logic to reduce database queries
- Change service_api message fetching order to match docs (descending order)
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Feb 14, 2025
@crazywoola crazywoola requested a review from laipz8200 February 14, 2025 05:39
@crazywoola
Copy link
Member

Please open an issue or link an existing issue in the description.

@hundredwz
Copy link
Contributor Author

Please open an issue or link an existing issue in the description.

Thanks for the reminder! I've created an issue #13723 to track this performance optimization work.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 15, 2025
@crazywoola crazywoola merged commit 284707c into langgenius:main Feb 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: Optimize chat message loading performance and message ordering
2 participants