Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: db insert error when notion page_name too long #14316

Merged
merged 1 commit into from
Feb 26, 2025
Merged

bugfix: db insert error when notion page_name too long #14316

merged 1 commit into from
Feb 26, 2025

Conversation

xlight
Copy link
Contributor

@xlight xlight commented Feb 25, 2025 •
edited by crazywoola
Loading

fix the bug:
SQL error cause by page_name too long when Sync Notion pages
Resolve #14314

Summary

Truncate page name to 255 characters to prevent DB field length errors
Fixes #<14314>

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@xlight
bugfix: db insert error when notion page_name too long
65ffb91 
fix the bug: 
SQL error cause by page_name too long when Sync Notion pages
langgenius#14314
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Feb 25, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2025
@crazywoola crazywoola merged commit 93a5ffb into langgenius:main Feb 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL error cause by page_name too long when Sync Notion pages
2 participants
@xlight @crazywoola