Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add gcompat for tailwindcss(-rails) #1184

Closed
itsyoshio opened this issue Jan 16, 2022 · 3 comments
Closed

Feature request: add gcompat for tailwindcss(-rails) #1184

itsyoshio opened this issue Jan 16, 2022 · 3 comments

Comments

@itsyoshio
Copy link

itsyoshio commented Jan 16, 2022

tailwindcss-rails or rather tailwindcss-cli requires build-base and gcompat in order to compile Tailwind.

Related Issue here

I'm aware that the Builder Dockerfile is meant for Rails 6 currently,
but would it be possible for you to include gcompat aswell?

Appreciated!

PS:
had 4m50s builds with your base images on Rails 6.1
after switching to Rails 7 i got 2m30s on the Build Stage

ledermann added a commit that referenced this issue Jan 16, 2022
This allows using tailwindcss-rails and tailwindcss-cli in build stage

Belongs to #1184
@ledermann
Copy link
Owner

ledermann commented Jan 16, 2022

Just added gcompact package, does this help? In my apps I'm using esbuild or webpack, so I didn't stumbled upon missing Alpine packages.

BTW: A few weeks ago I upgraded the Builder stuff to Rails 7, so it is faster to build a Rails 7 app than a Rails 6 app.

In my apps building time is about 1-2 minutes on GitHub Actions, see these examples which both use esbuild:

@itsyoshio
Copy link
Author

Thanks! Works like a Charm.
Getting 2m13s Builds now.

I'm on Gitlab with their public Runners & selfhosted ones on Kubernetes.
Definitely interested in Base Images for Rails 7.

@ledermann
Copy link
Owner

Cool, thanks for the feedback!

Definitely interested in Base Images for Rails 7.

Please note that this project is already ready on Rails 7. Means: The Builder image includes the gems rails, activerecord, etc. in version 7.0.1, so building an image for your Rails 7 app should be as fast as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants