Fix local testing mode by skipping downstream-only config setting #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we'd better replicate the the upstream config, but this hopefully moves things forward.
nickdesaulniers
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Ah! This is a downstream only change to buildbot! No wonder why I couldn't find any documentation about this. It's blocking my presubmit testing of #325, so +1.
|
Thanks for the review, merging now to hopefully avoid more wasted time due to the caused confusion. Once you get a chance @gkistanova it would be great if you could say more about the downstream buildbot patches and if there's a publicly accessible repo (perhaps it could be created under github.com/llvm ?). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we'd better replicate the the deployed config, but this hopefully moves things forward. Note: as the GitHub Actions pre-commit testing relies on "local testing mode", this PR fixes that too.
@gkistanova the requirements.txt just references a local checkout for the buildbot version being used - the other libs are all 3.11.7 so that's what I use for the GitHub actions and the guidance for "local testing mode". Is there a public repo of the buildbot fork that is deployed?