Development: Refactor isAtLeast occurrences in client and unify spy testing
#5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
client
krusche
changed the title
Development: Refactor isAtLeast occurrences in client
…ences # Conflicts: # src/main/webapp/app/exercises/shared/dashboards/tutor/exercise-assessment-dashboard.component.html
...p/app/course/dashboards/assessment-dashboard/assessment-dashboard-information.component.html
Outdated
Show resolved
Hide resolved
src/main/webapp/app/assessment/assessment-header/assessment-header.component.html
Outdated
Show resolved
Hide resolved
ge65cer
previously approved these changes
Sep 7, 2022
…ences # Conflicts: # src/main/webapp/app/exam/manage/exam-status.component.ts # src/test/javascript/spec/component/exam/manage/student-exams/exam-status.component.spec.ts # src/test/javascript/spec/component/hestia/git-diff-report/full-git-diff-entry.component.spec.ts # src/test/javascript/spec/component/hestia/git-diff-report/full-git-diff-report.component.spec.ts # src/test/javascript/spec/component/programming-exercise/programming-exercise-detail.component.spec.ts
JohannesStoehr
dismissed stale reviews from ge65cer and julian-christl
via
dac436d
JohannesStoehr
requested review from
julian-christl,
babyygemperor and
ge65cer
and removed request for
babyygemperor
Strohgelaender
approved these changes
Sep 12, 2022
julian-christl
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
Motivation and Context
#3742 refactored the client code such that exercise/course objects store the current access rights in the client. There were not used in some components.
Additionally GitHub was complaining about the checking of some spies in the client. These are fixed and unified in the code as well. (Point 11: https://docs.artemis.ase.in.tum.de/dev/guidelines/client-tests/)
Description
This PR refactores the last components to also use the exercise/course objects for the access rights.
The occurrences using the Metis service (e.g. post-header.component) is intentionally left out.
For checking the spies, we use .toHaveBeenCalledOnce()/.toHaveBeenCalledTimes(...) instead of .toHaveBeenCalled() and .not.toHaveBeenCalled() instead of .toHaveBeenCalled(0). This is unified in this PR
Review Progress
Code Review