Fixing external package usage for Python 3.7 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying the example from the module docs page, I got an ImportError for the quote_plus name and an AttributeError. This commit fixes the ImportError by pointing the import to urllib.parse if applicable, where the quote_plus name is located from Python 3.4 upwards. The AttributeError is addressed by importing the JWT class from the jwt module, and passing an object of the JWT class as the self argument for JWT.decode() instead of the auth token. The auth token should be the second positional argument, corresponding to the "message" parameter of decode().
maltiverse
force-pushed
the
master
branch
2 times, most recently
from
e83e5e3 to
981282f
Compare
|
I think this pull request no longer applies, the library has supported python3.7 for a long time (also for 3.8, 3.9, 3.10 and 3.11 at this moment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying the example from the module docs page, I got an ImportError for the quote_plus name and an AttributeError. This commit fixes the ImportError by pointing the import to urllib.parse if applicable, where the quote_plus name is located from Python 3.4 upwards. The AttributeError is addressed by importing the JWT class from the jwt module, and passing an object of the JWT class as the self argument for JWT.decode() instead of the auth token. The auth token should be the second positional argument, corresponding to the "message" parameter of decode().