Cleanup popup tip on popup removal (#5564)

* chore: cleanup leftover popup tip when popup is removed * chore: changelog * chore: clean-up event listeners on popup removal * chore: change changelog * chore: move close button removeEventListener outside this._map if * chore: remove popup test
maplibre · Feb 28, 2025 · 67b7f03 · 67b7f03
1 parent 1dc7c91
commit 67b7f03
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,7 +7,7 @@
 
 ### 🐞 Bug fixes
 
-- _...Add new stuff here..._
+- Remove closeButton event listener on popup.remove().
 
 ## 5.1.1
 

diff --git a/src/ui/popup.ts b/src/ui/popup.ts
@@ -273,6 +273,10 @@ export class Popup extends Evented {
             delete this._container;
         }
 
+        if(this._closeButton){
+            this._closeButton.removeEventListener('click', this._onClose);
+        }
+
         if (this._map) {
             this._map.off('move', this._update);
             this._map.off('move', this._onClose);