Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash position validation fails for <0 bearing, while -180 to 180 is a valid range #5461

Closed
stanislawpuda-tomtom opened this issue Feb 5, 2025 · 2 comments

Comments

@stanislawpuda-tomtom
Copy link
Contributor

stanislawpuda-tomtom commented Feb 5, 2025

maplibre-gl-js version: 5.1.0

browser: any

Steps to Trigger Behavior

  1. Open https://maplibre.org/maplibre-gl-js/docs/examples/hash-router.html#1/0/0
  2. Rotate map counter-clockwise, so the bearing is below zero (4th value in hash).
  3. Refresh the page.
  4. Position was cleared.

or

  1. Open https://maplibre.org/maplibre-gl-js/docs/examples/hash-router.html#1/0/0/-30/60
  2. Rotation was cleared.

Demonstration

very_small.mov

Expected Behavior

Position is successfully loaded for bearing in range -180 to 180.

Actual Behavior

Position is dropped when bearing is below 0.

@stanislawpuda-tomtom
Copy link
Contributor Author

#5462

PR to fix the issue.

@HarelM
Copy link
Collaborator

HarelM commented Feb 5, 2025

Fixed by #5462

@HarelM HarelM closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants