Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL hash bearing validation range #5462

Merged

Conversation

stanislawpuda-tomtom
Copy link
Contributor

Bearing rotation of the map has range: -180 to 180. In this PR: #5241 URL hash validation was introduced, however the allowed bearing range is set to 0 - 180. This PR fixes the value, and added tests to cover bearing range below zero.

Related to #5461 .

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM
Copy link
Collaborator

HarelM commented Feb 5, 2025

Thanks!

@HarelM HarelM merged commit e89b609 into maplibre:main Feb 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants