Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental "fix" for tile LOD when terrain is on #3994

Closed
wants to merge 1 commit into from

Conversation

olsen232
Copy link
Contributor

Experimenting with changing the behaviour of raster LOD when terrain is enabled - making it more similar to when terrain is disabled.

@olsen232 olsen232 marked this pull request as draft April 15, 2024 01:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (da9ac17) to head (9e2e766).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3994      +/-   ##
==========================================
- Coverage   86.89%   84.95%   -1.94%     
==========================================
  Files         242      242              
  Lines       32483    32483              
  Branches     2126     1910     -216     
==========================================
- Hits        28226    27597     -629     
- Misses       3328     3836     +508     
- Partials      929     1050     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@birkskyum
Copy link
Member

birkskyum commented Nov 5, 2024

@olsen232 , was this resolved by this PR?

@olsen232
Copy link
Contributor Author

olsen232 commented Nov 6, 2024

Yes, fixed or at least much improved
With a bug like "terrain LOD is too low for certain tiles at certain angles / zoom / terrain" it's always going to be subject to interpretation if it's a complete fix or just an improvement

@olsen232 olsen232 closed this Nov 6, 2024
@birkskyum
Copy link
Member

you're absolutely right - Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants