Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render world copies regression #5101

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Fix render world copies regression #5101

merged 8 commits into from
Nov 27, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Nov 23, 2024

This is a continue of the following PR - to fix a regression in rendering world copies.

It moves the tests of the covering tiles to a designated file.
It improves the covering zoom tests defintions

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

Cc: @NathanMOlson

NathanMOlson and others added 3 commits November 23, 2024 22:24
* set renderWorldCopies in GlobeTransform, and return it when not isGlobeRendering

* fix #5024

---------

Co-authored-by: Harel M <[email protected]>
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (1ac0a1b) to head (e264e7a).
Report is 1 commits behind head on main.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5101   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         279      279           
  Lines       38340    38347    +7     
  Branches     6698     6700    +2     
=======================================
+ Hits        35202    35209    +7     
  Misses       3006     3006           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM requested a review from kubapelc November 25, 2024 09:54
@HarelM HarelM enabled auto-merge (squash) November 27, 2024 08:48
@HarelM HarelM merged commit 662700d into main Nov 27, 2024
17 checks passed
@HarelM HarelM deleted the fix_world_copies branch November 27, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants