Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate for globe transition expression refactoring #5139

Merged
merged 20 commits into from
Dec 12, 2024

Final removal of TODOs and some minor clean up

6e658fb
Select commit
Loading
Failed to load commit list.
Merged

Facilitate for globe transition expression refactoring #5139

Final removal of TODOs and some minor clean up
6e658fb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 11, 2024 in 1s

85.88% of diff hit (target 91.84%)

View this Pull Request on Codecov

85.88% of diff hit (target 91.84%)

Annotations

Check warning on line 195 in src/geo/projection/camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/camera_helper.ts#L193-L195 

Added lines #L193 - L195 were not covered by tests

Check warning on line 37 in src/geo/projection/globe_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_camera_helper.ts#L37 

Added line #L37 was not covered by tests

Check warning on line 41 in src/geo/projection/globe_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_camera_helper.ts#L41 

Added line #L41 was not covered by tests

Check warning on line 45 in src/geo/projection/globe_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_camera_helper.ts#L45 

Added line #L45 was not covered by tests

Check warning on line 60 in src/geo/projection/globe_projection.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_projection.ts#L52-L60 

Added lines #L52 - L60 were not covered by tests

Check warning on line 94 in src/geo/projection/globe_projection.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_projection.ts#L94 

Added line #L94 was not covered by tests

Check warning on line 102 in src/geo/projection/globe_projection.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_projection.ts#L102 

Added line #L102 was not covered by tests

Check warning on line 124 in src/geo/projection/globe_projection.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_projection.ts#L124 

Added line #L124 was not covered by tests

Check warning on line 112 in src/geo/projection/globe_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_transform.ts#L112 

Added line #L112 was not covered by tests

Check warning on line 115 in src/geo/projection/globe_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_transform.ts#L115 

Added line #L115 was not covered by tests

Check warning on line 362 in src/geo/projection/globe_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_transform.ts#L362 

Added line #L362 was not covered by tests

Check warning on line 383 in src/geo/projection/globe_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_transform.ts#L383 

Added line #L383 was not covered by tests

Check warning on line 400 in src/geo/projection/globe_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_transform.ts#L400 

Added line #L400 was not covered by tests

Check warning on line 438 in src/geo/projection/globe_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_transform.ts#L438 

Added line #L438 was not covered by tests

Check warning on line 442 in src/geo/projection/globe_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/globe_transform.ts#L442 

Added line #L442 was not covered by tests

Check warning on line 111 in src/geo/projection/mercator_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/mercator_transform.ts#L111 

Added line #L111 was not covered by tests

Check warning on line 114 in src/geo/projection/mercator_transform.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/mercator_transform.ts#L114 

Added line #L114 was not covered by tests

Check warning on line 28 in src/geo/projection/projection_factory.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/projection_factory.ts#L23-L28 

Added lines #L23 - L28 were not covered by tests

Check warning on line 61 in src/geo/projection/projection_factory.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/projection_factory.ts#L59-L61 

Added lines #L59 - L61 were not covered by tests

Check warning on line 27 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L23-L27 

Added lines #L23 - L27 were not covered by tests

Check warning on line 36 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L31-L36 

Added lines #L31 - L36 were not covered by tests

Check warning on line 41 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L40-L41 

Added lines #L40 - L41 were not covered by tests

Check warning on line 48 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L43-L48 

Added lines #L43 - L48 were not covered by tests

Check warning on line 52 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L50-L52 

Added lines #L50 - L52 were not covered by tests

Check warning on line 74 in src/geo/projection/vertical_perspective_camera_helper.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/geo/projection/vertical_perspective_camera_helper.ts#L65-L74 

Added lines #L65 - L74 were not covered by tests
View more details on Codecov