Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert breaking changes ingeomerty-type #5331

Merged
merged 6 commits into from
Jan 12, 2025
Merged

Revert breaking changes ingeomerty-type #5331

merged 6 commits into from
Jan 12, 2025

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jan 12, 2025

Launch Checklist

This reverts the changes made in geometry-type.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes. - see render tests
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM HarelM requested a review from louwers January 12, 2025 14:30
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (9c4f03b) to head (7bf5e7d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5331   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         282      282           
  Lines       38908    38908           
  Branches     6827     6826    -1     
=======================================
  Hits        35735    35735           
  Misses       3046     3046           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 12, 2025

So, to the elephant in the room now: 5.0.1 or 6.0.0?

@HarelM HarelM changed the title Revert geomerty-type changes of version 5.0 Revert breaking changes ingeomerty-type Jan 12, 2025
@HarelM HarelM merged commit a9918e6 into main Jan 12, 2025
17 checks passed
@HarelM HarelM deleted the revert-geometry-type branch January 12, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiPolygon passes Polygon filter unexpectedly
2 participants