-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cjk unicode lookup #5421
Fix/cjk unicode lookup #5421
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5421 +/- ##
=======================================
Coverage 91.94% 91.95%
=======================================
Files 282 282
Lines 39039 39050 +11
Branches 6849 6860 +11
=======================================
+ Hits 35896 35907 +11
Misses 3016 3016
Partials 127 127 ☔ View full report in Codecov by Sentry. |
Thanks for taking the time to solve this! |
I understand I should make expected image as |
I can't run I followed this docs but it doesn't work for me. |
You can download the render test html report from the failing CI run, open it in the browser and right click to save the image and check it in. |
You don't have to create all the image, just those that are different between OSs. |
@HarelM Thanks for advice! fixed |
Launch Checklist
Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
Briefly describe the changes in this PR.
Link to related issues.
Include before/after visuals or gifs if this PR includes visual changes.
Write tests for all new functionality.
Add an entry to
CHANGELOG.md
under the## main
section.Issue: [label] Full-width hyphen in Japanese
ー
is accidently disappeared #5420before
あーい、う。
becomesあいう
. some symbols are ignored.after