RD-393 #10
RD-393 #10
Conversation
|
Very minor display bug that happens during the animated transition between globe and mercator. It does not even happen all the time, it looks like only with some specific heading range for the model and only with some camera angle. Super nice, no big deal, but it makes me think that maybe the internal ThreeJS scene should be plane-globe.mp4 |
This actually works OK as far as I tested: render(_gl: WebGLRenderingContext | WebGL2RenderingContext, options: CustomRenderMethodInput) {
// Not rendering during the animated transition
if (options.defaultProjectionData.projectionTransition > EPSILON && options.defaultProjectionData.projectionTransition < (1 - EPSILON)) {
return;
}
...
} |
| * The `defaultProjectionData` seems to be incorrect when the globe projection is used and the zoom is high (and projection is changing to mercator). | ||
| * Waiting for help: https://github.com/maplibre/maplibre-gl-js/issues/5117 | ||
| */ | ||
| if ("_mercatorTransform" in this.map.transform === true) { |
There was a problem hiding this comment.
It would be best to avoid relying on private props as they are not guaranteed to stay in future versions
| * Waiting for help: https://github.com/maplibre/maplibre-gl-js/issues/5117 | ||
| */ | ||
| if ("_mercatorTransform" in this.map.transform === true) { | ||
| defaultProjectionData = |
There was a problem hiding this comment.
I was wondering why can't we just use the regular options.defaultprojectionData or even reach it with this.map.transform.getProjectionDataForCustomLayer() and while starting to go down the rabbit hole, I ended up with the issue you posted on the MapLibre repo maplibre/maplibre-gl-js#5117 😅
There was a problem hiding this comment.
So i suppose we just leave this like that until it's being fixed
* RD-393 (#10) * Update image links + replace plugin by module (#13) * Add position indicators models * Install maptiler sdk 3 * Update 3D layer to sdk 3 * Add example * Add comments * Add offset * Make linter happy * Refactor mount everest example * Update examples to sdk v3 * Make biome happy * Remove break line * Fix model position issue on projection change animation --------- Co-authored-by: Jonathan Lurie <[email protected]> * Make biome happy * RD-453_telemetry (#12) * Update image links + replace plugin by module (#13) * Add position indicators models * Install maptiler sdk 3 * Update 3D layer to sdk 3 * Add example * Add comments * Add offset * Make linter happy * Refactor mount everest example * Update examples to sdk v3 * Make biome happy * Remove break line * Add telemetry module registration * Make registration works for multiple map instances * Simplify telemetry * Update sdk to v3.0.0-rc.4 * Fix model position issue on projection change animation --------- Co-authored-by: Jonathan Lurie <[email protected]> * RD-492_maplibre-v5.0.0-pre10 (#15) * Update sdk version * Update examples * Bump version * Fix version * Update dependencies * Update demos * Fix dev mode * Clean up --------- Co-authored-by: Jonathan Lurie <[email protected]>
Objective
To be able the 3D plugin with SDK v3 (and globe projection).
https://maptiler.atlassian.net/browse/RD-393
Description
Maplibre introduced breaking changes to 3D models placement
Acceptance
Using examples
Checklist