-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caddyfile support #4
Caddyfile support #4
Conversation
45e1e74
to
d2b6765
Compare
d2b6765
to
b09335a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that my review matters too much here, but LGTM 😄
Latest release can make use of this now: https://github.com/caddyserver/caddy/releases/tag/v2.3.0-beta.1 Think you could review/try it @mastercactapus? |
:) we're waiting for this as well |
@crysper For now, you can build like this:
I just updated the |
Thanks a lost @francislavoie .Wondering how stable the beta is because we want to use it in production. Any timeframe when the 2.3 comes out of beta? |
There's been a small handful of commits to the master branch since to fix small bugs and to add a few small features, but otherwise it's pretty stable. You could also build right from master instead (specify the commit hash of the latest commit on master instead of the beta tag in the xcaddy command) to get all the current fixes. We don't have a set time when we'll release the stable 2.3 version but it's essentially ready now. We're just waiting for people to try it and report any possible issues. You should try it on your staging environment first, then you can use it in production. |
I would add a disclaimer of course, to always thoroughly test beta software before using it in production. :) But no major issues have been reported recently, and everything significant I can think of is fixed on the master branch. Francis is right though, we just need more people to use it at this point before we tag the release. So please do try the beta -- carefully, within your tolerances -- and let us know if there's bugs! |
Thanks @francislavoie and @mholt We compiled the 2.3.0-beta.1, made some tests and put it on a low-risk production environment (100+ req/minute). If something comes up will report. |
Caddy v2.3 is now released https://github.com/caddyserver/caddy/releases/tag/v2.3.0 @mastercactapus could you please merge this PR? |
@francislavoie thanks for this PR. I'm already using it on a prod environment successfully 😄 @mastercactapus any chances to get this merged? |
Thank you Nathaniel! Really appreciate it. :) |
FYI @mholt, @JackEllis
Closes #1
This is now possible since caddyserver/caddy#3836 is merged.
I haven't tested this yet, slight issue withxcaddy
preventing me from compiling, but @mholt is looking into it.Tested, the above Caddyfile gives this JSON:
Ready to go!