update to newer emersion/go-smtp and go-sasl #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For systems on which certbot or other LetsEncrypt setups are already deployed, re-using the existing certificates might be more convenient to set up. When receiving SIGHUP, the certificates are reloaded. Sending SIGHUP can be done from the certbot deploy-hook, for example.
|
Thanks a lot! I will try to look into this soon. |
|
Thanks a lot again and I am really sorry for the long wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to pull in the latest version of go-smtp and go-sasl just to be sure I have all available bug fixes, if any.
This turned out to be quite the undertaking, because:
go-smtp-proxyis no longer active, so I integrated it as a fork. Not sure if we should just rebuild the functionality into the backend, or if it makes sense to keep it as a separate layer — haven’t looked at it in much detail yet.I’m not sure if everything is right; would appreciate a review. I also included the commits of my other PR #3 for simplicity. Would you mind merging that one? I’ve been using it in production for years at this point.