Improve procarg0 handling #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgollahon
force-pushed
the
improve-procarg0-handling
branch
from
6fa0f20 to
f4f90d4
Compare
- These are now fully covered.
- Since ruby 2.7+ defines `start_with?` on symbols as well as strings, the `#to_s` here is irrelevant. This locks `mutant` a bit more tightly to ruby 2.7+ but I think, based on the gemspec, that that's probably acceptable.
- It's possible to have an unnamed procarg0 argument by doing something like this: `foo { |(*)| }` and a few other niche cases. This resolves those crashes.
- Also solves a bug where the mutation to prefix `_` to potentially unused arguments wasn't applying properly in cases like this: `foo { |(a,b)| }` and instead of prefixing both `a` as `_a` and `b` as `_b` it would only emit the strange case of `foo { |_a| }`
- Additionally, we have slightly simpler code by just recursing and letting the rename be handled by the `arg` node mutator.
dgollahon
force-pushed
the
improve-procarg0-handling
branch
from
6bb4ba3 to
ab0bc91
Compare
- Adds mutations of the form `foo { |(a, b)| }` -> `foo { |a, b| }. This does not apply in the case of 1 argument because that would force writing `foo { |a,| }` over `foo { |a| }`
- Closes #784
- I discovered the procarg0 edge case because I was trying to test something unrelated via the corpus tests. Unfortunately, the corpus tests were never upgraded to use the modern AST as brought in through `unparser`. This means that we've actually had corpus tests that were not generating valid mutations or properly exercising the parts of mutant that make use of the modern AST for years.
dgollahon
force-pushed
the
improve-procarg0-handling
branch
from
79371e4 to
8eea07e
Compare
mbj
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things, all motivated by improving procarg0 support:
foo { |(*)| }.foo { |(a, b)| }tofoo { |(_a, b)| }andfoo { |(a, _b)| }instead of the less useful mutation to onlyfoo { |_a| }.foo { |(a, b)| }->foo { |a, b| }mutation.parserAST