Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a spelling mistask #35954

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix a spelling mistask #35954

merged 1 commit into from
Sep 19, 2024

Conversation

amanofuyu
Copy link
Contributor

fix a spelling mistask

Description

Motivation

Additional details

Related issues and pull requests

fix a spelling mistask
@amanofuyu amanofuyu requested a review from a team as a code owner September 19, 2024 10:30
@amanofuyu amanofuyu requested review from chrisdavidmills and removed request for a team September 19, 2024 10:30
@github-actions github-actions bot added Content:Glossary Glossary entries size/xs [PR only] 0-5 LoC changed labels Sep 19, 2024
@pransh15
Copy link

pransh15 commented Sep 19, 2024

Thanks for submitting a PR, the correct spelling is indeed, progress.

@pransh15 pransh15 closed this Sep 19, 2024
@pransh15 pransh15 reopened this Sep 19, 2024
Copy link
Contributor

Preview URLs

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@OnkarRuikar I'm a bit puzzled why this is not caught by the spell checker.

@Josh-Cena Josh-Cena merged commit b6abba9 into mdn:main Sep 19, 2024
11 checks passed
@OnkarRuikar
Copy link
Contributor

@Josh-Cena Because the Cspell thinks it's a valid word:

fsh$ npx cspell trace "progess"
Word     F Dictionary           Dictionary Location
progess  - [flagWords]*         From Settings `flagWords`
progess  - [ignoreWords]*       From Settings `ignoreWords`
progess  - [suggestWords]*      From Settings `suggestWords`
progess  - [words]*             From Settings `words`
...
progess  - django*              node_modules/@cspell/dict-django/dict/django.txt
prog+ess * en_us*               node_modules/@cspell/dict-en_us/en_US.trie.gz        <=== Note
progess  - en-us-common-misspe* node_modules/@cspell/dict-en-common-misspellings/dict-en-us.yaml
...

@Josh-Cena
Copy link
Member

Josh-Cena commented Sep 20, 2024

Nice, I didn't know you can do that. And weird that progess gets allowed. Honestly not sure how to interpret that trace.

@OnkarRuikar
Copy link
Contributor

The prog+ess in the trace means that we have "allowCompoundWords": true set and the prefix prog and suffix ess from the en_US dictionary make the progess word. We have to explicitly forbid the word using !progess. I'll do it in the upcoming weekly spell-check round.

@Josh-Cena
Copy link
Member

Out of curiosity I wonder why they have it in the dictionary. And there's very possibly other uncaught typos like this.

@OnkarRuikar
Copy link
Contributor

Out of curiosity I wonder why they have it in the dictionary. And there's very possibly other uncaught typos like this.

Let us continue the discussion in #36004

fiji-flo pushed a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants