-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add ability to get classDefs from classDb #6190
base: develop
Are you sure you want to change the base?
chore: Add ability to get classDefs from classDb #6190
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6190 +/- ##
=======================================
Coverage 3.88% 3.88%
=======================================
Files 399 398 -1
Lines 42055 42048 -7
Branches 638 638
=======================================
Hits 1635 1635
+ Misses 40420 40413 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
E2E tests failing as of right now due to argos but they should actually be good.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment
packages/mermaid/src/diagrams/class/classDiagram-styles.spec.js
Outdated
Show resolved
Hide resolved
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
@yari-dewalt Please look at @sidharthv96 comments, and resolve them, so that we can move forward with this PR |
@ashishjain0512 Resolved, however like @sidharthv96 mentioned since getClassDefs() is only going to be used in alana we can keep the rest and move this part into a separate pr for alana? Or should we just include it in mermaid? Thoughts? |
📑 Summary
Creates and exposes public function to fetch classDefs inside the classDb. Also includes change to properly split styles when inserting into its object styles array.
📏 Design Decisions
getClassDefs() returns the defined style classes from inside the classDb so we have access to them.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.