Dynamic Lookup of Compiler Name for Managed PE for BA4001 #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaskohl-msft
force-pushed
the
dev/lukaskohl/compiler-name-pdb-managed
branch
2 times, most recently
from
7b73f1a to
6de0077
Compare
|
@lukaskohl-msft is it feasible to have any tests for this change? |
Adds the compiler name for managed PE's by looking into compiland details. Additionally slightly restructures the rule while ensuring comparable data.
lukaskohl-msft
force-pushed
the
dev/lukaskohl/compiler-name-pdb-managed
branch
from
6de0077 to
9dfc036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the compiler name for managed PE's by looking into compiland details.
Additionally slightly restructures the rule while ensuring comparable data.