Fix issue with VS 2019 building and added VS2019 testing #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghgary
approved these changes
Jun 21, 2021
| @@ -62,7 +62,65 @@ jobs: | |||
| testResultsFiles: built\Out\windows_$(buildPlatform)\$(buildConfiguration)\GLTFSDK.Test\GLTFSDK.Test.log | |||
| condition: and(succeeded(), in(variables['buildPlatform'], 'Win32', 'x64')) | |||
|
|
|||
| - job: WindowsVcPkg | |||
| - job: Windows_VS2019 | |||
There was a problem hiding this comment.
We probably should start factoring this out a bit as to not repeat the same thing multiple times.
There was a problem hiding this comment.
Talked offline about this. Will refactor in separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cast to a validation check to prevent a signed/unsigned mismatch error when the glTF-SDK code is used with VS 2019. This also adds building against VS 2019 to verify build integrity against that version.