chore: introduce update snapshot settings #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
update_options
branch
from
5d0c085 to
248e911
Compare
mxschmitt
approved these changes
Dec 14, 2024
| @@ -144,16 +146,14 @@ export class SettingsView extends DisposableBase implements vscodeTypes.WebviewV | |||
| svg: `<div class="action-indent"></div>`, | |||
| text: this._vscode.l10n.t('Run global setup'), | |||
| location: 'rareActions', | |||
| disabled: !this._models.selectedModel() || !this._models.selectedModel()!.canRunGlobalHooks('setup'), | |||
| hidden: this._settingsModel.runGlobalSetupOnEachRun.get(), | |||
| disabled: this._settingsModel.runGlobalSetupOnEachRun.get() || !this._models.selectedModel() || !this._models.selectedModel()!.canRunGlobalHooks('setup'), | |||
There was a problem hiding this comment.
Why was this hidden condition removed?
There was a problem hiding this comment.
I wanted UI to stop jumpin on update
| @@ -105,8 +102,6 @@ export class TestServerConnection implements TestServerInterface, TestServerInte | |||
| this._onReportEmitter.fire(params); | |||
| else if (method === 'stdio') | |||
| this._onStdioEmitter.fire(params); | |||
| else if (method === 'listChanged') | |||
There was a problem hiding this comment.
This was removed in one of Simon's refactorings, it is not used in vscode or UI mode anymore
| @@ -147,6 +147,8 @@ export class ReusedBrowser implements vscodeTypes.Disposable { | |||
| this._pageCountChanged(params.pageCount); | |||
| }); | |||
| this._backend.on('sourceChanged', async params => { | |||
| if (!this._cancelRecording) | |||
There was a problem hiding this comment.
This is a fix of a nasty issue, it is unrelated, but running tests ends up editing sources otherwise :)
pavelfeldman
force-pushed
the
update_options
branch
from
248e911 to
49e8650
Compare
dgozman
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.