Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use first-class properties for toolComponent.organization and product #1716

Closed
ghost opened this issue Nov 9, 2019 · 0 comments
Closed

Use first-class properties for toolComponent.organization and product #1716

ghost opened this issue Nov 9, 2019 · 0 comments
Labels
enhancement resolved-fixed

Comments

@ghost
Copy link

ghost commented Nov 9, 2019 •
edited by ghost
Loading

Today SarifLogger puts the CompanyName and ProductName properties of FileVersionInfo into the driver's property bag. But SARIF 2.1.0 has first-class properties toolComponent.organization and .product, so we should use them.

FileVersionInfo.Comment remains in the driver's property bag.
@ghost ghost added the enhancement label Nov 9, 2019
@ghost ghost self-assigned this Nov 9, 2019
ghost pushed a commit that referenced this issue Nov 9, 2019
Fix #1716: Use first-class properties for toolComponent.organization …
24ae75d 
…and product
@ghost ghost closed this as completed in f0b8164 Nov 12, 2019
@ghost ghost added the resolved-fixed label Nov 12, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants