Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all JSON.NET use to 11.0 (to support .NET standard 2.0) #2172

Merged
merged 7 commits into from
Dec 2, 2020

Conversation

michaelcfanning
Copy link
Member

@michaelcfanning michaelcfanning commented Dec 2, 2020

Oops. We said we updated to 11.0 previously but we neglected to update the core SARIF dll.

@eddynaka, take a look. Please merge if you agree with the change.

@eddynaka
Copy link
Collaborator

eddynaka commented Dec 2, 2020

@michaelcfanning , we have to take a look at our .netstandard2.1 reference.
Why:


1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1662,5): warning NU1702: ProjectReference 'C:\Microsoft\sarif-pattern-matcher\Src\sarif-sdk\src\Sarif.Driver\Sarif.Driver.csproj' was resolved using '.NETFramework,Version=v4.7.2' instead of the project target framework '.NETStandard,Version=v2.0'. This project may not be fully compatible with your project.
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1662,5): warning NU1702: ProjectReference 'C:\Microsoft\sarif-pattern-matcher\Src\sarif-sdk\src\Sarif\Sarif.csproj' was resolved using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This project may not be fully compatible with your project.

This came from the new spam project...
i think our library should target .netstandard2.0 and our tool can keep using netcoreapp3.1.

@eddynaka eddynaka merged commit 1276353 into main Dec 2, 2020
@eddynaka eddynaka deleted the json-net-11 branch December 2, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants