Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove options from per-target context creation. #2655

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Remove options from per-target context creation. #2655

merged 3 commits into from
Apr 13, 2023

Conversation

michaelcfanning
Copy link
Member

@michaelcfanning michaelcfanning commented Apr 12, 2023 •
edited
Loading

  • BUG: Eliminate erroneous Posted log file successfully message when context PostUri is non-null but empty. #2655
  • BUG: Resolves IOException raised by calling FileSystem.ReadAllText on file locked for write (but not read). #2655
  • NEW: MultithreadedAnalyzeCommandBase.Tool is now public to support in-memory analysis (and logging) of targets. #2639

@michaelcfanning michaelcfanning marked this pull request as ready for review April 12, 2023 23:55
HulonJenkins
HulonJenkins approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@HulonJenkins HulonJenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelcfanning michaelcfanning merged commit 36b4792 into main Apr 13, 2023
@michaelcfanning michaelcfanning deleted the pipeline-change-etc branch April 13, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HulonJenkins HulonJenkins HulonJenkins approved these changes

@EasyRhinoMSFT EasyRhinoMSFT Awaiting requested review from EasyRhinoMSFT EasyRhinoMSFT is a code owner

@marmegh marmegh Awaiting requested review from marmegh

@cfaucon cfaucon Awaiting requested review from cfaucon cfaucon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelcfanning @HulonJenkins