Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-47032: Network compression #622

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DOCSP-47032: Network compression #622

wants to merge 4 commits into from

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Feb 21, 2025 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-47032

Staging Links

  • connection
  • connection/network-compression
  • versioning/whats-new

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Feb 21, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-java ready!

    Name Link
    🔨 Latest commit c2ea31d
    🔍 Latest deploy log https://app.netlify.com/sites/docs-java/deploys/67b8f22306112b0008647b15
    😎 Deploy Preview https://deploy-preview-622--docs-java.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    lindseymoore
    lindseymoore approved these changes Feb 21, 2025
    View reviewed changes
    Copy link
    Collaborator

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Awesome LGTM :)

    source/connection/network-compression.txt Outdated
    Comment on lines 55 to 56
    - Use the ``compressors`` parameter in your connection string
    - Chain the ``compressorList()`` method to the ``MongoClientSettings.builder()`` method
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    - Use the ``compressors`` parameter in your connection string
    - Chain the ``compressorList()`` method to the ``MongoClientSettings.builder()`` method
    - Use the ``compressors`` parameter in your connection string.
    - Chain the ``compressorList()`` method to the ``MongoClientSettings.builder()`` method.

    S: Would use a period since there is an implied you.

    @norareidy norareidy marked this pull request as ready for review February 21, 2025 21:37
    @norareidy norareidy requested a review from a team as a code owner February 21, 2025 21:37
    @norareidy norareidy requested review from NathanQingyangXu and removed request for a team February 21, 2025 21:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lindseymoore lindseymoore lindseymoore approved these changes

    @NathanQingyangXu NathanQingyangXu Awaiting requested review from NathanQingyangXu NathanQingyangXu is a code owner automatically assigned from mongodb/dbx-java

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @norareidy @lindseymoore