[useScrollTrigger] Do nothing if target is null #45441
Open
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
options.target
isundefined
it tried to default to thewindow
.In my case I have another component that may or may not be mounted at a given time, so the ref to it might be null.
Right now I do:
but that will default to the
window
, and if its not present it will throw an error. Which is not what I want exactly.This change just disables the hook if
null
is explicitly passed.