Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Fix "no rows" overlay not showing with active aggregation #16466

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

KenanYusuf
Copy link
Member

@KenanYusuf KenanYusuf commented Feb 5, 2025

Hides the pinned aggregation row if there aren't any values to aggregate.

Before

CodeSandbox

Screenshot 2025-02-05 at 10 31 46

After

CodeSandbox

Screenshot 2025-02-05 at 10 32 20

Fixes #16453

@KenanYusuf KenanYusuf added component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse plan: Premium Impact at least one Premium user feature: Aggregation Related to the data grid Aggregation feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Feb 5, 2025
@mui-bot
Copy link

mui-bot commented Feb 5, 2025

Deploy preview: https://deploy-preview-16466--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 63eac89

@KenanYusuf KenanYusuf marked this pull request as ready for review February 5, 2025 11:05
@KenanYusuf KenanYusuf requested a review from a team February 5, 2025 11:05
@KenanYusuf KenanYusuf merged commit 7c2e4b8 into mui:master Feb 5, 2025
18 checks passed
Copy link

github-actions bot commented Feb 5, 2025

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature needs cherry-pick The PR should be cherry-picked to master after merge plan: Premium Impact at least one Premium user regression A bug, but worse v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] aggregationModel does not show noRowsLabel if no rows are provided
3 participants