[DateRangePicker] Avoid unnecessary field section focusing #16474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
bug 🐛
LukasTy
commented
Feb 5, 2025
packages/x-date-pickers-pro/src/internals/hooks/useEnrichedRangePickerField.ts
Outdated
Show resolved
Hide resolved
|
Deploy preview: https://deploy-preview-16474--material-ui-x.netlify.app/ |
LukasTy
added
needs cherry-pick
LukasTy
commented
Feb 12, 2025
| @@ -49,6 +49,15 @@ export const useRangePosition = ( | |||
|
|
|||
| const sections = singleInputFieldRef.current.getSections(); | |||
| const targetActiveSectionIndex = newRangePosition === 'start' ? 0 : sections.length / 2; | |||
| const activeSectionIndex = singleInputFieldRef.current.getActiveSectionIndex(); | |||
| // if the active section is already within the target range, we don't need to update it. | |||
There was a problem hiding this comment.
Avoid resetting/jumping focus to the first section when switching range positions with the mouse on a single input range field.
Screen.Recording.2025-02-12.at.14.57.49.mov
| if (!sectionListRef.current) { | ||
| if ( | ||
| !sectionListRef.current || | ||
| // if the field is already focused, we don't need to focus it again |
There was a problem hiding this comment.
Avoid resetting/jumping focus to the first section when switching fields with the mouse on a multi input range field.
Screen.Recording.2025-02-12.at.15.00.30.mov
| @@ -202,6 +202,9 @@ export const useFieldV6TextField: UseFieldTextField<false> = (params) => { | |||
| return nextSectionIndex === -1 ? sections.length - 1 : nextSectionIndex - 1; | |||
| }, | |||
| focusField: (newSelectedSection = 0) => { | |||
| if (getActiveElement(document) === inputRef.current) { | |||
There was a problem hiding this comment.
Avoid resetting/jumping focus to the first section when switching fields with the mouse on a multi input v6 (native input) range field.
Screen.Recording.2025-02-12.at.15.02.32.mov
flaviendelangle
approved these changes
Feb 13, 2025
|
Cherry-pick PRs will be created targeting branches: v7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15880.