Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Fix time related aria labels to depend on ampm flag value #16572

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 13, 2025

Follow up on #16522 (comment).

Do you think it warrants an entry in the migration guide? 🤔

Changelog

  • The aria-label on the <Clock /> component and Time Picker opening button has been fixed to rely on the set ampm property instead of defaulting to the user's locale.

@LukasTy LukasTy added breaking change component: pickers This is the name of the generic UI component, not the React module! v8.x labels Feb 13, 2025
@LukasTy LukasTy self-assigned this Feb 13, 2025
@mui-bot
Copy link

mui-bot commented Feb 13, 2025

Deploy preview: https://deploy-preview-16572--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4b510d8

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it warrants an entry in the migration guide? 🤔

No I don't think it's necessary

@LukasTy LukasTy added the component: TimePicker The React component. label Feb 14, 2025
@LukasTy LukasTy merged commit 6e19f24 into mui:master Feb 14, 2025
26 checks passed
@LukasTy LukasTy deleted the fix-time-aria-labels-to-depend-on-ampm branch February 14, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. v8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants