Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts-pro] Fix automatic type overloads #16579

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

JCQuintas
Copy link
Member

Fixes #16573

Empty imports get optimized out of the build by typescript. To overcome that we can replace import {} from '' with import ''

@JCQuintas JCQuintas added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! labels Feb 13, 2025
@JCQuintas JCQuintas self-assigned this Feb 13, 2025
@JCQuintas JCQuintas changed the title [charts] Fix type imports v7 [charts] Fix automatic type overloads Feb 13, 2025
@mui-bot
Copy link

mui-bot commented Feb 13, 2025

Deploy preview: https://deploy-preview-16579--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 89af15a

Copy link
Member

@bernardobelchior bernardobelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for v8, right? If so, do we want to backport the fix for v7?

@JCQuintas
Copy link
Member Author

No, this is for v7 only

I'll add it to v8 as well

@JCQuintas JCQuintas merged commit dc2b329 into mui:v7.x Feb 13, 2025
19 checks passed
@JCQuintas JCQuintas deleted the fix-type-imports-v7 branch February 13, 2025 19:27
@oliviertassinari oliviertassinari added typescript v7.x plan: Pro Impact at least one Pro user labels Feb 13, 2025
@JCQuintas JCQuintas changed the title [charts] Fix automatic type overloads [charts-pro] Fix automatic type overloads Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user typescript v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants