Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix: base Select menuprops onClose #16643

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Feb 18, 2025

Fixes Select components not closing on click-away.

Having onClose: undefined in MenuProps removes the default close handler.

@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Feb 18, 2025
@romgrk romgrk requested a review from a team February 18, 2025 17:58
@mui-bot
Copy link

mui-bot commented Feb 18, 2025

Deploy preview: https://deploy-preview-16643--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 138b452

@cherniavskii cherniavskii added the regression A bug, but worse label Feb 19, 2025
@cherniavskii cherniavskii merged commit 4e7aaeb into mui:master Feb 19, 2025
22 checks passed
@romgrk romgrk deleted the fix-base-select-onclose-2 branch February 19, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants