Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix aria-hidden console error when scrollbar is dragged #16829

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Mar 5, 2025

Fixes #16706

aria-hidden cannot be removed because of #16706 (comment)
tabIndex cannot be removed because we don't want focus on the scrollbar

@arminmeh arminmeh added bug 🐛 Something doesn't work accessibility a11y component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Mar 5, 2025
@arminmeh arminmeh requested a review from a team March 5, 2025 10:46
@mui-bot
Copy link

mui-bot commented Mar 5, 2025

Deploy preview: https://deploy-preview-16829--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b87a8d9

@arminmeh arminmeh force-pushed the fix-scrollbar-aria branch from bd188c6 to b87a8d9 Compare March 5, 2025 10:58
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever!

@arminmeh arminmeh merged commit f3d0658 into mui:master Mar 5, 2025
18 checks passed
Copy link

github-actions bot commented Mar 5, 2025

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] aria-hidden warning when scrolling
3 participants