Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Fix undefined behaving differently from missing value for axis size #16844

Merged

Conversation

bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Mar 6, 2025

Fix undefined behaving differently from missing value for axis size. Also fixed the same issue for the position property.

Example:

<BarChart xAxis={[{ height: undefined }]} />

had a different behavior than:

<BarChart xAxis={[{}]} />

Before

height:

Screen.Recording.2025-03-06.at.09.58.58.mov

position:

Screen.Recording.2025-03-06.at.10.58.48.mov

After

height:

Screen.Recording.2025-03-06.at.11.01.41.mov

position:

Screen.Recording.2025-03-06.at.11.00.17.mov

@bernardobelchior bernardobelchior force-pushed the fix-undefined-axis-size branch from ff6e1cb to b583388 Compare March 6, 2025 08:58
@bernardobelchior bernardobelchior changed the title [charts] Fix undefined behaving differently than missing value for axis size [charts] Fix undefined behaving differently from missing value for axis size Mar 6, 2025
@mui-bot
Copy link

mui-bot commented Mar 6, 2025

Deploy preview: https://deploy-preview-16844--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 6e0107d

@bernardobelchior bernardobelchior force-pushed the fix-undefined-axis-size branch from b583388 to c72c112 Compare March 6, 2025 09:18
@bernardobelchior bernardobelchior force-pushed the fix-undefined-axis-size branch from c72c112 to 8303fb8 Compare March 6, 2025 09:55
@bernardobelchior bernardobelchior marked this pull request as ready for review March 6, 2025 10:03
@zannager zannager added the component: charts This is the name of the generic UI component, not the React module! label Mar 6, 2025
@bernardobelchior bernardobelchior added the bug 🐛 Something doesn't work label Mar 6, 2025
Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #16844 will not alter performance

Comparing bernardobelchior:fix-undefined-axis-size (6e0107d) with master (03c32eb)

Summary

✅ 7 untouched benchmarks

@bernardobelchior bernardobelchior merged commit fc41af5 into mui:master Mar 6, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants